fix: extend filter path resolution to support at/path filters from extensions
#13067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
mcanouil
changed the title
at: pre-ast filtersat/path filters from extensions
mcanouil
changed the title
at/path filters from extensionsat/path filters from extensions
The "at" resolution actually happens after path resolution. Apply same as in resolveFilters() entryPoints definition
|
Could this be for 1.8? |
cscheid
approved these changes
Aug 20, 2025
|
Several extensions (including several of mines) needed this so I expect to be thoroughly tested in broader context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the
resolveFilterExtension()function to handle filters from extensions specified withpathandat.Add tests to verify the correct resolution of filter paths (extension) from objects.
Fixes #11750 (
ERROR (src/resources/filters/./common/wrapped-filter.lua:200) cannot open <extension-name>: No such file or directory)